Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repro: Add --allow-missing #9437

Merged
merged 1 commit into from
May 16, 2023
Merged

repro: Add --allow-missing #9437

merged 1 commit into from
May 16, 2023

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented May 10, 2023 •
edited
Loading

Point 2 in #9375 (comment)

Requires #9434

@daavoo daavoo changed the title Repro allow missing repro: Add --allow-missing May 10, 2023
@daavoo daavoo requested a review from dberenbaum May 10, 2023 13:32
daavoo
daavoo commented May 10, 2023
View reviewed changes
dvc/stage/run.py
def _pull_missing_deps(stage):
for dep in stage.deps:
if not dep.exists:
stage.repo.pull(dep.def_path)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skshetry I couldn't find a way to do this without using the high level API

@daavoo daavoo self-assigned this May 10, 2023
@codecov
Copy link

codecov bot commented May 10, 2023 •
edited
Loading

Codecov Report

Patch coverage: 96.87% and project coverage change: -0.01 ⚠️

Comparison is base (f888544) 91.60% compared to head (3070f7d) 91.60%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9437      +/-   ##
==========================================
- Coverage   91.60%   91.60%   -0.01%     
==========================================
  Files         489      489              
  Lines       38178    38201      +23     
  Branches     5472     5477       +5     
==========================================
+ Hits        34974    34994      +20     
  Misses       2640     2640              
- Partials      564      567       +3
Impacted Files Coverage Δ
tests/unit/command/test_repro.py 100.00% <ø> (ø)
dvc/stage/run.py 93.33% <83.33%> (-3.10%) ⬇️
dvc/commands/repro.py 100.00% <100.00%> (ø)
dvc/stage/__init__.py 93.93% <100.00%> (+0.04%) ⬆️
tests/func/test_repro_multistage.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

dberenbaum
dberenbaum approved these changes May 11, 2023
View reviewed changes
dvc/commands/repro.py Outdated Show resolved Hide resolved
@dberenbaum
Copy link
Collaborator

Looks great! This one covers a lot of use cases in #5369. Run dvc exp run --allow-missing --dry. If it fails, your pipeline isn't clean.

@daavoo daavoo force-pushed the repro-allow-missing branch 2 times, most recently from f2398da to a1a49cc Compare May 12, 2023 12:52
@daavoo daavoo mentioned this pull request May 16, 2023
Merged
@daavoo daavoo added A: pipelines Related to the pipelines feature feature is a feature labels May 16, 2023
@daavoo daavoo force-pushed the repro-allow-missing branch from a1a49cc to 12a856b Compare May 16, 2023 14:18
@daavoo daavoo marked this pull request as ready for review May 16, 2023 14:18
@daavoo daavoo enabled auto-merge (rebase) May 16, 2023 14:18
@dberenbaum
Copy link
Collaborator

@daavoo Could you coordinate with @dacbd to figure out which flags we should be using when running cloud experiments? It seems like we should drop the dvc pull step in the cloud experiments workflow and instead use something like dvc exp run --pull --allow-missing. We should also probably update CML docs to use these flags.

@daavoo daavoo force-pushed the repro-allow-missing branch from 12a856b to 3070f7d Compare May 16, 2023 18:45
@daavoo daavoo merged commit 64beb15 into main May 16, 2023
@daavoo daavoo deleted the repro-allow-missing branch May 16, 2023 20:43
This was referenced May 18, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dberenbaum dberenbaum dberenbaum approved these changes

Assignees

@daavoo daavoo

Labels
A: pipelines Related to the pipelines feature feature is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daavoo @dberenbaum